D12936: Rewrite workspace KCM in QtQuick

[Yuri Chornoivan]

yurchor added inline comments.

INLINE COMMENTS

> CMakeLists.txt:2
>  # KI18N Translation Domain for this library
> -add_definitions(-DTRANSLATION_DOMAIN=\"kcmworkspaceoptions\")
> -########### next target ###############
> +add_definitions(-DTRANSLATION_DOMAIN=\"kcm_workspace\")
>  

That will not work. The name of the translation catalog is "kcm_workspaceoptions" (see below).

> workspaceoptions.cpp:34
>  {
> -    KAboutData *about =
> -    new KAboutData(QStringLiteral("kcmworkspaceoptions"), i18n("Global options for the Plasma Workspace"),
> -                   QStringLiteral("1.0"), QString(), KAboutLicense::GPL,
> -                   i18n("(c) 2009 Marco Martin"));
> -
> -    about->addAuthor(i18n("Marco Martin"), i18n("Maintainer"), QStringLiteral("notmart at gmail.com"));
> +    KAboutData* about = new KAboutData(QStringLiteral("kcm_workspace"),
> +                    i18n("Plasma Workspace global options"),

This might not work with translations as the translation catalog is named "kcm_workspaceoptions".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham, #plasma
Cc: yurchor, zzag, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180518/45a5bad9/attachment-0001.html>