D12936: Rewrite workspace KCM in QtQuick

Vlad Zagorodniy noreply at phabricator.kde.org
Thu May 17 17:36:21 UTC 2018


zzag added inline comments.

INLINE COMMENTS

> workspaceoptions.cpp:110
> +    // Prevent from binding loop
> +    if( m_stateToolTip == state ) {
> +        return;

Coding style nitpick: No whitespace after `(` and before `)`. Also, I believe, there should be a whitespace between control statement keyword and opening parentheses.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  bug393547-SingleDoubleClickFunc

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham, #plasma
Cc: zzag, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180517/45963115/attachment.html>


More information about the Plasma-devel mailing list