D12849: Improve layout of fonts kcm
Henrik Fehlauer
noreply at phabricator.kde.org
Thu May 17 10:11:02 UTC 2018
rkflx added a comment.
In D12849#264040 <https://phabricator.kde.org/D12849#264040>, @progwolff wrote:
> Not sure if this patch should be landed in this half-finished state. Might be an improvement, but might also be perceived as a regression.
> I'm away for some hours now, so if anyone feels that this patch should go in, please feel free to land it.
@mart @broulik Should this land now (with possible improvements for the final release), or is this for 5.14 (meaning we'll change around the UI //again//)?
---
> In D12849#263865 <https://phabricator.kde.org/D12849#263865>, @rkflx wrote:
>
>> share/kpackage/kcms/kcm_fonts/contents/ui/main.qml:273:17: QML SpinBox: Binding loop detected for property "value"
>>
>
>
> The second on doesn't show up for me...
After much head-scratching I found how to reproduce: Remove the `forceFontDPI` key from `~/.config/kcmfonts` (hint hint <https://community.kde.org/Infrastructure/Phabricator#Perform_QA>).
REPOSITORY
R119 Plasma Desktop
BRANCH
fonts_kcm_layout (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D12849
To: progwolff, mart, abetts, ngraham
Cc: broulik, zzag, rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180517/d463210b/attachment.html>
More information about the Plasma-devel
mailing list