D12936: Rewrite workspace KCM in QtQuick

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> kcm.cpp:107
> +{
> +    if( m_stateToolTip == state ) return;
> +

needs braces. see https://community.kde.org/Policies/Kdelibs_Coding_Style#Braces

> metadata.desktop:2
> +[Desktop Entry]
> +Name=Workspace
> +Name[ar]=مساحة العمل

I believe you should remove all `Name[...]=...` and only leave the `Name=Workspace` line. Same for `Comment`. This stuff is added by the translation team.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180517/99679377/attachment-0001.html>