D12936: kcm_workspace is finished.

[Furkan Tokac]

furkantokac added a comment.


  In D12936#263939 <https://phabricator.kde.org/D12936#263939>, @ngraham wrote:
  
  > In D12936#263907 <https://phabricator.kde.org/D12936#263907>, @furkantokac wrote:
  >
  > > In D12936#263886 <https://phabricator.kde.org/D12936#263886>, @davidedmundson wrote:
  > >
  > > > Can you change the title to something more specific.
  > >
  > >
  > > There will be other options so that time it will make more sense I think (see the ss). Maybe we can change it to "General Workspace Settings". If you have any suggestion, you're welcome.
  > >  F5852492: Screenshot_20180517_015512.png <https://phabricator.kde.org/F5852492>
  >
  >
  > David meant the title of the patch, not the title of the KCM. :)
  
  
  Got it :) I fixed "Default" button and some important things and applied the suggestions. Update is coming.

INLINE COMMENTS

> kcm.cpp:42
> +
> +    setToolTip(true);
> +}

This is unnecessary. Just ignore it.

> ngraham wrote in ExclGroupBox.qml:1
> Is this file actually used at all?

ExclGroupBox.qml and ToolTip.qml are not used now but they'll be used. I forgot to remove them.

> davidedmundson wrote in ToolTip.qml:2
> is this copy pasted from somewhere?

Yeap it's Roman's implementation used in "input" kcm. Shouldn't I use it ?

> davidedmundson wrote in main.qml:24
> this is unused in every file

Actually it is used. It has "units" in it.

Example

  Layouts.ColumnLayout {
      id: maincol
      spacing: units.largeSpacing

> davidedmundson wrote in main.qml:37
> why is here a column inside a columnlayout?

Items under the "Column" has smallSpacing. Items under the "ColumnLayout" has largeSpacing. Otherwise, it looks bad.

> davidedmundson wrote in main.qml:43
> i18n

Thanks, fixing...

> davidedmundson wrote in metadata.desktop:105-107
> remove all X-Plasma lines

I'm removing.
Can you explain why ? Just want to learn.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180517/8d643924/attachment-0001.html>