D12936: kcm_workspace is finished.

[David Edmundson]

davidedmundson added a comment.


  Can you change the title to something more specific.

INLINE COMMENTS

> ToolTip.qml:2
> +/*
> + * Copyright 2017 Roman Gilg <subdiff at gmail.com>
> + *

is this copy pasted from somewhere?

> main.qml:24
> +
> +import org.kde.plasma.core 2.0 as PlasmaCore
> +

this is unused in every file

> main.qml:37
> +            // General Settings
> +            Column {
> +                spacing: units.smallSpacing

why is here a column inside a columnlayout?

> main.qml:43
> +                    id: generalSettings
> +                    text: "General Settings"
> +                }

i18n

> metadata.desktop:105-107
> +X-Plasma-API=declarativeappletscript
> +
> +X-Plasma-MainScript=ui/main.qml

remove all X-Plasma lines

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180516/4eb540bb/attachment.html>