D12928: Make Apply/Discard settings prompt consistent with rest of settings

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When switching between shortcut categories with pending changes, a user would only be given the opportunity to discard them or cancel out and save manually.
  This makes it consistent with what System Settings usually offers, a Discard, Apply, and Cancel option

TEST PLAN
  Before
  F5851537: Screenshot_20180516_150831.png <https://phabricator.kde.org/F5851537>
  After
  F5851538: Screenshot_20180516_150809.png <https://phabricator.kde.org/F5851538>
  
  - Apply: applies new shortcut setting and sends it over so it works immediately, then switches categories
  - Discard: discards new shortcut setting, then switches categories
  - Cancel: does nothing. It still switches the current index in the table view but that is an unrelated bug, possibly porting bug or Qt 5 behavior change

REPOSITORY
  R101 KHotKeys

REVISION DETAIL
  https://phabricator.kde.org/D12928

AFFECTED FILES
  kcm_hotkeys/kcm_hotkeys.cpp

To: broulik, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180516/cb005b26/attachment.html>