D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

Julian Wolff noreply at phabricator.kde.org
Wed May 16 09:16:41 UTC 2018


progwolff created this revision.
progwolff added a reviewer: rkflx.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
progwolff requested review of this revision.

REVISION SUMMARY
  The fonts kcm did only parse a local config file. Global and default settings were not recognized.
  With this patch, all global config files are parsed before the local file is parsed.
  This allows us to drop the "Vendor default" option.
  
  This patch also fixes some changes not recognized (apply button disabled).

TEST PLAN
  Delete ~/.config/fontconfig/fonts.conf.
  Start `kcmshell5 fonts`. The default/global settings should be displayed. 
  Change some settings. The apply button should be enabled.
  Save. A new config file should be created.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fonts_kcm_globalConfigFiles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12925

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/kxftconfig.cpp
  kcms/fonts/kxftconfig.h
  kcms/fonts/package/contents/ui/main.qml

To: progwolff, rkflx
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180516/a38bde7d/attachment-0001.html>


More information about the Plasma-devel mailing list