D10297: Add new "Tools" button above System Monitor's process list

[gregormi]

gregormi marked an inline comment as done.
gregormi added inline comments.

INLINE COMMENTS

> rkflx wrote in CMakeLists.txt:37
> Is `Plasma` needed here? If so, I think this needs more discussion or should be made optional.
> 
> KSysGuard can also be used in other desktop environments and perhaps other apps consume this library too (KDevelop?), all of them might not want to bring in a huge dependency on Plasma.

No, it's not. I'll remove that.

> rkflx wrote in ProcessWidgetUI.ui:71
> Unrelated change?
> 
> (Comment applies also to a bunch of other places with the same change.)

I removed those now.

> rkflx wrote in ksysguardprocesslist.cpp:419-420
> Sweeper and KMag do not show up for me, even though I have both of them installed. Is your naming correct?
> 
> (Sidenote: This smells like it should be handled by your KMoreTools, although that would probably require some changes there first… :)

I fixed the desktop names.

> rkflx wrote in ksysguardprocesslist.cpp:423
> This looks a bit odd. I would organize this with linebreaks alone, no need for separate code blocks.

Done.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180515/84f5736f/attachment.html>