D12893: Fix Logout screen countdown not cancelling on multi-monitor setups
David Edmundson
noreply at phabricator.kde.org
Tue May 15 09:38:25 UTC 2018
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
The logout greeter theme has a timer that invokes the current action if
no keyboard interaction has taken place.
This cancel on keyboard nav is broken on multiple monitor setups as even
if a user is interacting with one, the timer from another can still
fire.
Fix is via JS singleton library as the timer is very theme specific. I
didn't want to add anything in shutdowndlg.cpp as it would be breaking
layering.
BUG: 394249
TEST PLAN
Had multi monitor setup
Pressed key on one screen. All timer UIs cleared, nothing happened after 30 seconds
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12893
AFFECTED FILES
lookandfeel/contents/logout/Logout.qml
lookandfeel/contents/logout/LogoutButton.qml
lookandfeel/contents/logout/timer.js
To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180515/2c929b27/attachment-0001.html>
More information about the Plasma-devel
mailing list