D12855: Move Widget search field to its own row so it doesn't get compressed

[Scott Harvey]

sharvey marked 13 inline comments as done.
sharvey added inline comments.

INLINE COMMENTS

> ngraham wrote in WidgetExplorer.qml:235
> I mean, could we do something like `newSearchRow.height = searchInput.height + (units.smallSpacing * 2)` or something like that? Would that work?
> 
> Now that I think about it, instead of conditionally adjusting the height in this if/else block, could we just have this toggle the `showingSearch` property? Does that not work? In fact, I wonder why we need the `onClicked` as well as `onCheckedChanged` lines at all. Perhaps those could be simplified into just one.

A method to my madness! The size is there so the search bar announces its arrival by expanding the row, pushing the widget grid downward, and appearing. And then again in reverse.

Otherwise, there's just an empty space there, waiting for the search box to appear.

It's not much eye candy, but just a little bit.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180515/478aab8f/attachment.html>