D12855: Move search field to its own row so it doesn't get compressed

Scott Harvey noreply at phabricator.kde.org
Mon May 14 09:14:48 UTC 2018


sharvey added inline comments.

INLINE COMMENTS

> ngraham wrote in WidgetExplorer.qml:157
> ? Not sure The extra comment adds anything. Instead we should just remove the commented-out code in a new patch IMHO.

I'm always unclear what to do when I find blocks of other people's comments. Some reviewers absolutely loathe comments being left in; others don't seem to object as much. I've asked for a comment policy to be put together as part of the new-onboarding initiative. I was taught to comment my code for clarity, but not to leave blocks of work-in-progress code like this behind. I hesitated to take it out in case someone was planning on returning to it, but I probably shouldn't have added the graffiti. I'll remove my unnecessary side comment.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180514/ed7b132b/attachment.html>


More information about the Plasma-devel mailing list