D12102: Port Language KCM to Qt Quick

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.qml:66
> +            delegate: Kirigami.BasicListItem {
> +                width: ListView.view.width
> +

sorry, counter what i told you before, setting an explicit width: in lists in overlaysheets actually breaks them, https://imgur.com/a/CPMhtYX
this line should be removed

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180511/2e63a264/attachment-0001.html>