D12819: Fix the global drawer handle "click"

Emmanuel Lepage Vallee noreply at phabricator.kde.org
Fri May 11 08:02:35 UTC 2018


lepagevalleeemmanuel created this revision.
lepagevalleeemmanuel added reviewers: davidedmundson, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
lepagevalleeemmanuel requested review of this revision.

REVISION SUMMARY
  Bug:
  
  - drawerOpen is not set when dragging manually
  - Widgets using a `Loader{}` active on `drawerOpen || peeking` are shown only when clicked or during peeking, not after the drawer is dragged open
  
  Step to reproduce:
  
  - Drag manually the drawer to open
  - Click on the handle
  - Notice it takes 2 click to close it
  
  Ref: https://github.com/ring-project/ring/issues/49

TEST PLAN
  - Manual testing

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12819

AFFECTED FILES
  src/controls/templates/OverlayDrawer.qml

To: lepagevalleeemmanuel, davidedmundson, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180511/2d98ec22/attachment.html>


More information about the Plasma-devel mailing list