D12698: WIP: Show SNI to install browser-side extension

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> browserintegrationreminder.cpp:138
> +    QMenu *menu = new QMenu;
> +    auto action = new QAction(i18n("Do not show again"));
> +    menu->addAction(action);

`auto` usage is not consistent. Also, it would be better not to use `auto` to deduce raw pointer types, e.g. it would be much better as this

  auto *menu = new QMenu;
  auto *action = new QAction(i18n("Do not show again"));

https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Do-not-use-auto-to-deduce-a-raw-pointer

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D12698

To: hein, davidedmundson, apol, mart, #plasma
Cc: alexeymin, zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180509/f684c50f/attachment-0001.html>