D12698: WIP: Show SNI to install browser-side extension

Eike Hein noreply at phabricator.kde.org
Tue May 8 08:11:33 UTC 2018


hein added reviewers: apol, mart, Plasma.
hein added a comment.


  The code looks fine to me. I was questioning if `config.writeEntry("shownCount", 100);` should be MAX_SHOW_COUNT + 1 instead for a moment, but this is safer in case it gets bumped later.
  
  I'm not sure if this should be an SNI or a persistent notification (which however I guess we don't really have currently ...) instead. Then again it fits the pattern of things like update modifiers.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D12698

To: hein, davidedmundson, apol, mart, #plasma
Cc: hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180508/42c8b49e/attachment.html>


More information about the Plasma-devel mailing list