D12702: Avoid giving an stderr to kwallet

[Maximiliano Curia]

maximilianocuria created this revision.
maximilianocuria added reviewers: Plasma, aacid.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
maximilianocuria requested review of this revision.

REVISION SUMMARY
  The fixes for CVE-2018-10380 introduced a regression for most users not
  using kde, and some for kde sessions. In particular the reorder of the
  close calls and creating a new socket caused that the socket is always
  assigned the file descriptor 2, aka stderr.
  
  BUG: 393856

TEST PLAN
  It works

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  cve_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12702

AFFECTED FILES
  pam_kwallet.c

To: maximilianocuria, #plasma, aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180504/1a768106/attachment.html>