D12686: Fix sidebar view regression of not prompting about unsaved changes
David Edmundson
noreply at phabricator.kde.org
Fri May 4 13:25:42 UTC 2018
davidedmundson updated this revision to Diff 33627.
davidedmundson added a comment.
Also fixes the UI on cancel
Checkable property would be updated internally on clicked, breaking our binding and
becoming checked on clicked regardless
The background color is set by if (checked || highlighted) so we can use that instead
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12686?vs=33566&id=33627
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12686
AFFECTED FILES
sidebar/SidebarMode.cpp
sidebar/package/contents/ui/CategoriesPage.qml
sidebar/package/contents/ui/SubCategoryPage.qml
To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180504/fe5d2282/attachment.html>
More information about the Plasma-devel
mailing list