D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Marco Martin noreply at phabricator.kde.org
Wed May 2 13:27:25 UTC 2018


mart added a comment.


  In D12040#257172 <https://phabricator.kde.org/D12040#257172>, @Zren wrote:
  
  > In D12040#257170 <https://phabricator.kde.org/D12040#257170>, @mart wrote:
  >
  > > so, if the qpointer is used in a connect, it needs to have .data() to work on gcc 4.8.
  > >  if accessed normally, it doesn't need it
  >
  >
  > So I need to change
  >
  >   connect(m_newStuffDialog, &QDialog::accepted, this, &WallpaperPlugin::newStuffFinished);
  >   
  >
  > to
  >
  >   connect(m_newStuffDialog.data(), &QDialog::accepted, this, &WallpaperPlugin::newStuffFinished);
  >   
  >
  > to support gcc 4.8?
  
  
  yup

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180502/c8d543f8/attachment.html>


More information about the Plasma-devel mailing list