D12563: [Run Command] Add closable property so that close button can be disabled.

[Dennis Scheffer]

dscheffer added a comment.


  In D12563#257018 <https://phabricator.kde.org/D12563#257018>, @mart wrote:
  
  > what's the exact use case? what plasmoid are you writing? (btw, you can't use that qml file in a plasmoid, if you want to embed parts of krunner in a plasmoids, those are components coming from milou)
  
  
  Thanks for commenting! I'm not exactly sure what you mean by "you can't". It works just fine for my use case. I wrote a C++ plugin that loads the RunCommand.qml using KPackage and subsequently registers the file with the qml type system. It just bothers me that I have a close button in my full representation that does nothing. I could just modify a local copy of RunCommand.qml (which I did) but I think it would be a cleaner solution to use the system wide file in case of future enhancements. Here is a link to my project on github: https://github.com/dscheffer/KRunner-Plasmoid

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12563

To: dscheffer, broulik
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180502/ff15a00a/attachment.html>