Late API change to KWayland for upcoming Frameworks release

Roman Gilg subdiff at gmail.com
Wed May 2 04:19:19 UTC 2018


I have the following patch to KWayland adding a property for per
OutputDevcie color correction via color curve adjustment:
https://phabricator.kde.org/D12388

The problem is that Frameworks tag is on Saturday, but if the patch
does not get in with next Frameworks release, I'm blocked on multiple
other patches for KWin and Plasma that otherwise could land in 5.13.

There seems to be an unwritten rule against API changes to Frameworks
in the last week before tagging, but since KWayland is an independent
framework only relevant to the fast-moving Wayland session and the
additional code paths will only become relevant in practice with the
upcoming changes to Plasma in 5.13 I would like to make an exception
to this unwritten rule. Because of the unwritten rule I want to hear
other opinions on this decision first though.

Regarding the API changes one other question: I have not increased the
Wayland protocol version numbers of the affected protocol extensions
in the patch, because they are only used internally and KScreen as
well as KWin will just ignore the additional property functioning as
before as long as no support has been added to them with a future
Plasma release. Is this alright?

Cheers
Roman


More information about the Plasma-devel mailing list