D11333: introduce candidateContainments

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> desktopview.cpp:55
> +    if (items.length() > 0) {
> +        qDebug()<<"double activity insertion attempted";
> +        info->deleteLater();

Remove or cleanup

> desktopview.cpp:93
> +{
> +    QHash<int, QByteArray> roles;
> +    roles[Id] = "id";

Use initializer list

> desktopview.h:41
> +        Id = Qt::UserRole + 1,
> +        Name,
> +        Current,

use `Qt::DisplayRole` for that

> desktopview.h:45
> +    };
> +    Q_ENUM(ActivityRoles)
> +

You're not using those from QML (not needed for `model` magic property)

> shellcorona.cpp:1228
>  
> +    QStringList existingActivities = m_activityController->activities();
> +    for (const auto &id : existingActivities) {

`const`

> shellcorona.cpp:1571
>      m_activityContainmentPlugins.insert(id, defaultContainmentPlugin());
> +    for (const auto desktopView : m_desktopViewforId) {
> +        desktopView->activitiesModel()->addActivity(id, containmentGraphicsItemPreview(id, desktopView->containment()->screen()));

`qAsConst`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11333

To: mart, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180327/3c0724b1/attachment-0001.html>