D11726: Vastly simplify image wallpaper code

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> main.qml:62
>          }
> +        loadImage();
>      }

are you sure none of the *changed signals will be triggered i nthe beginning? this could call loadImage twice

> main.qml:80
> +    }
> +    onFillModeChanged: loadTimer.start();
> +    onModelImageChanged: loadTimer.start();

the result will be the same with a 0 interval, but would be more correct-correct using loadTimer.restart() instead?

> main.qml:146
> +    }
> +    replaceExit: Transition {
> +        OpacityAnimator {

if the new image is fading in, i don't think the old image should be fading out, as at some point of the anmiation both items would be semitransparent, in that case the black on the back of everything would be creeping in for a while, so if you transition between 2 light wallpaper, you would see a transition to a darker result, then going lighter again

replaceExit: Transition {

      PauseAnimation {
          duration: wallpaper.configuration.TransitionAnimationDuration
      }
  }

seems to have a more pleasing effect

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11726

To: davidedmundson, #plasma
Cc: mart, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180327/f125196d/attachment.html>