D11743: [notifications applet] Fix two qml warnings about assigning [undefined]

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Mar 27 11:31:02 UTC 2018


broulik added inline comments.

INLINE COMMENTS

> NotificationDelegate.qml:122
>              hasDefaultAction: model.hasDefaultAction
> -            hasConfigureAction: model.hasConfigureAction
> +            hasConfigureAction: model.hasConfigureAction || false
>              urls: {

Can you do that in the place where it sets `hasConfigureAction`, I find it odd that this one needs an explicit check but the other one doesn't

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11743

To: kossebau, #plasma
Cc: broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180327/f085e2bd/attachment.html>


More information about the Plasma-devel mailing list