D11663: Add InlineMessage type and Gallery app example page

David Edmundson noreply at phabricator.kde.org
Mon Mar 26 19:05:06 UTC 2018


davidedmundson added a comment.


  Very nice!

INLINE COMMENTS

> InlineMessage.qml:225-226
> +                wrapMode: Text.WordWrap
> +                elide: Text.ElideRight
> +                verticalAlignment: lineCount > 1 ? Qt.AlignVCenter : Qt.AlignTop
> +

I don't think either of these two lines will work as you intend as you've not constrained the label height anywhere

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180326/6c879efc/attachment.html>


More information about the Plasma-devel mailing list