D11726: Vastly simplify image wallpaper code

David Edmundson noreply at phabricator.kde.org
Mon Mar 26 18:03:14 UTC 2018


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The image wallpaper is a mess of 4 different fade functions, some not in
  sync, and very complicated swapping images about.
  
  This simplifies the whole thing by using a StackView, we just pop our
  setup with a new configuration on and it handles deleting old objects
  when the transition ends.
  
  Code is 1/3 the size, whislt doing the same thing and should result in 
  having fewer items about.
  
  In addition with this patch changing the transition effect in future 
  would be super trivial.

TEST PLAN
  Set as both image and wallpaper
  Renders stuff as before

REPOSITORY
  R120 Plasma Workspace

BRANCH
  davidedmundson/wallpaperrewrite

REVISION DETAIL
  https://phabricator.kde.org/D11726

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180326/5acf7959/attachment.html>


More information about the Plasma-devel mailing list