D11721: Fix issues in models to pass ModelTest

David Rosca noreply at phabricator.kde.org
Mon Mar 26 17:06:10 UTC 2018


drosca added inline comments.

INLINE COMMENTS

> broulik wrote in maps.h:116
> This creates a temporary list just to iterate it, better use iterators and then `key()` provided by it (I bet there's even a fancy `std` algorithm for what you're trying to do here)

Some fancy `std` algorithm gives me iterator, but I need index (and `std::distance` is another traverse because map iterator is not RandomAccessIterator).

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11721

To: drosca, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180326/b0c8fe14/attachment.html>


More information about the Plasma-devel mailing list