D11613: call beginRemoveRows before removing the data

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It's perfectly valid to call ::data() from within beginRemoveRows, proxy
  models will do it all the time. Also at the time of calling rowCount()
  should be correct at the time of calling beginRemoveRows, this throws an
  assert on Qt5.11.
  
  This patch follows the normal beginRemoveRows / actual removal /
  endRemoveRows policy.
  
  Data insertion is unchaged in this patch, it's less of an issue to have
  data before you announce it than the other way round.

TEST PLAN
  Plasma stayed up for more than a few minutes

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11613

AFFECTED FILES
  src/maps.h
  src/pulseaudio.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180323/33778da3/attachment.html>