D11584: Set a transient parent for SNI context menus

David Edmundson noreply at phabricator.kde.org
Thu Mar 22 23:41:01 UTC 2018


davidedmundson added inline comments.

INLINE COMMENTS

> StatusNotifierItem.qml:63
>      onClicked: {
> -        var pos = plasmoid.nativeInterface.popupPosition(taskIcon, 0, 0);
> +        var pos = plasmoid.nativeInterface.popupPosition(taskIcon, mouse.x, mouse.y);
>  

This change is unrelated, and not a change I would support.

> systemtray.cpp:297
>          KAcceleratorManager::manage(menu);
> +        menu->winId();
> +        menu->windowHandle()->setTransientParent(statusNotifierIcon->window());

This part is all fine.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11584

To: fvogt, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180322/989c3552/attachment.html>


More information about the Plasma-devel mailing list