D11519: NotifcationPopup: workaround crash in Qt when appending empty actions array

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Mar 20 18:28:28 UTC 2018


apol added inline comments.

INLINE COMMENTS

> NotificationPopup.qml:61
> +        notificationItem.actions.clear();
> +        if (notificationProperties.actions.length > 0) {
> +            notificationItem.actions.append(notificationProperties.actions);

Add a comment indicating what's workarounding?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11519

To: dvratil
Cc: apol, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180320/56a47eb5/attachment.html>


More information about the Plasma-devel mailing list