D11198: [libbreezecommon] add box shadow helper

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Fix it (std::erf), then ship it ! 
  I have had no time to work on an alternative QGradient blur, and wont in the near future. In the meanwhile lets use this code (that you have spent quite some time on already). 
  There is still time to revisit it in the future. 
  Thanks !

INLINE COMMENTS

> breezeboxshadowhelper.cpp:41
> +    double kernelNorm = 0.0;
> +    double lastInt = 0.5 * erf((-radius - 0.5) / den);
> +

erf -> std::erf (since c++11). 
same elsewhere. I think it is clearer to add the namespace explicitly, now that it is properly defined.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180320/2d888507/attachment.html>