D11289: checkable FormLayout items

[Marco Martin]

mart added a comment.


  can you provide screenshots as well t see how does it look?

INLINE COMMENTS

> FormLayout.qml:185
>          id: buddyComponent
> -        Kirigami.Heading {
> +        CheckBox {
>              id: labelItem

what i'm concerned is that this makes every field a checkbox, no matter if it should or should not be one.

> FormLayout.qml:213
>                  sequence: labelItem.Kirigami.MnemonicData.sequence
>                  onActivated: item.Kirigami.FormData.buddyFor.forceActiveFocus()
>              }

should the behavior of the shortcut change to toggle the checkbox instead when the item is checkable?

> FormLayout.qml:226
> +            }
> +            Rectangle {
> +                enabled: labelItem.indicator.enabled

What's this rectangle about?

> formlayoutattached.h:110
> +     */
> +    Q_PROPERTY(bool enabled READ enabled WRITE setEnabled NOTIFY enabledChanged)
> +

api wise an "enabled" property doesn't have anything to do with checkboxes

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11289

To: progwolff, #vdg, #kirigami
Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180319/478b2de1/attachment-0001.html>