D11198: [libbreezecommon] add box shadow helper

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezeboxshadowhelper.h:30
> +class QRect;
> +
> +

I think the "rule" is to not use forward declarations for classes external to once project. 
Reason is that the upstream library might decide to turn a class into a struct, or an alias into future changes, which will then break your code.
Please include the headers here directly, and remove them from the cpp

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180318/b35cce09/attachment.html>