D11362: Fix double top padding on scrollable pages with headers
Nathaniel Graham
noreply at phabricator.kde.org
Thu Mar 15 18:35:00 UTC 2018
ngraham created this revision.
ngraham added reviewers: mart, apol, Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Kirigami was erroneously allocating extra top padding to ScrollablePages with headers, despite the fact that the headers allocale enough space for themselves automatically.
This patch fixes the issue and resolves a visual glitch in Discover arising from the use of standard ToolBarApplicationHeaders.
TEST PLAN
Viewed all pages in Kirigami Gallery and made sure there were no visual regressions.
Discover, before:
Discover, after:
REPOSITORY
R169 Kirigami
BRANCH
fix-scrollablepage-redundant-top-padding (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D11362
AFFECTED FILES
src/controls/ScrollablePage.qml
To: ngraham, mart, apol, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180315/0f234d0b/attachment-0001.html>
More information about the Plasma-devel
mailing list