D11333: introduce the function containmentGraphicsItemPreview

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  ShellCorona only creates the containment in currentActivityChanged, so this swiping stuff isn't going to work until you've first switched containment an existing way, then started swiping.

INLINE COMMENTS

> desktopview.cpp:201
>  
> +QQuickItem *DesktopView::containmentItemForActivity(const QString &activity)
> +{

In the main code path shellcorona is responsible for assigning containments to desktopviews.

In this code path DesktopView is extracting the relevant containments for itself.

That's super messy, please redesign.

> shellcorona.cpp:1234
>  
> +Plasma::Containment *ShellCorona::containmentGraphicsItemPreview(const QString& activity, int screenNum)
> +{

This is generically finding a containment.

The method name and comment shouldn't have anything to do with what 1 usage of it is doing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11333

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180314/1ed198bc/attachment-0001.html>