D11316: Components for Cards

[Julian Wolff]

progwolff added a comment.


  Marked some typos. Note that I am not a native speaker, so please re-check them.
  
  Besides that, looks good to me.

INLINE COMMENTS

> CardsGridViewGallery.qml:61
> +            wrapMode: Text.WordWrap
> +            text: "The Kirigami types AbstractCard and Card are used to implement the popular Card pattern used on many mobile and web platforms that is used to display a collection of information or actions.\n Besides the Card components, Kirigami offers also 3 kinds of views and positioners to help to present cards with beautiful and responsive layouts.\n\nIn this page, CardsGridView shows an example on how to put cards in a grid view, generated by a Qt model.\nThe behavior is same as CardsLayout, and it allowes cards to be put in one or two columns depending from the available width.\nCardsGridView has the limitation that every Card must have the same exact height, so cellHeight must be manually set to a value in which the content fits for every item.\nIf possible use cards only when you don't need to instantiate that many and use CardsLayout intead."
> +        }

If I'm not wrong: allowes -> allows

> CardsLayoutGallery.qml:78
> +                    wrapMode: Text.WordWrap
> +                    text: "An AbstractCard is the simplest form of card. Its just a rectangle with a shadow, which can contain any Item in it. It can also have items assigned to the Header or Footer properties. in this case a Kirigami.Heading is its header and a Label with WordWrap is the contentItem."
> +                }

Its just a -> It's just a
. in -> . In

> CardsLayoutGallery.qml:87
> +                    wrapMode: Text.WordWrap
> +                    text: "This is an AbstractCard with a Label with WordWrap in it and nothing else, it's the simplest form Cards can be found in.\nAn AbstractCard can be clicked itself, with the usual onClicked signal handler and the showClickFeedback property can be used if the click should show any kind of visual feedback. It is recomended to set it to true if you plan to make the card reactive on any kind of click."
> +                }

recomended -> recommended

> CardsLayoutGallery.qml:215
> +                    topPadding: avatarIcon.height/2
> +                    text: "It's possible to customize the look and feel for Cards too, if the no padding behavior for headers is needed. This is usually discouraged in order to have greater consistency, but in some cases the design requires a more fancy layout, as shown in this example of a Card. if a custom header is used, the title and icon in the banner property shouldn't be used. If a custom footer is used (which is discouraged), actions shouldn't be used."
> +                }

. if -> . If

> CardsLayoutGallery.qml:247
> +                    wrapMode: Text.WordWrap
> +                    text: "A card can optionally have horizontal orientation.\n in this case will be wider than tall, so is fit to be used also in a ColumnLayout.\nIf you need to put it in a CardsLayout, it will have by default a columnSpan of 2 (which can be overridden)."
> +                }

.\n in -> .\n In

> CardsListViewGallery.qml:61
> +            wrapMode: Text.WordWrap
> +            text: "The Kirigami types AbstractCard and Card are used to implement the popular Card pattern used on many mobile and web platforms that is used to display a collection of information or actions.\n Besides the Card components, Kirigami offers also 3 kinds of views and positioners to help to present cards with beautiful and responsive layouts.\n\nIn this page, CardsListView is used to do a list view of AbstractCard subclasses with a custom layout inside.\n CardsListView should be used only with cards which can look good at any horizontal size, so It is recommended to use directly AbstractCard with an appropriate layout inside, because they are stretching for the whole list width.\nTherefore is discouraged to use it with the Card type, unless it has Horizontal as headerOrientation.\n The choice between using this view with AbstractCard or a normal ListView with AbstractListItem/BasicListItem is purely a choice based on aestetics alone."
> +        }

so It is -> so it is

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11316

To: mart, #kirigami
Cc: progwolff, plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180314/4c909f9b/attachment-0001.html>