D11205: Fix ActionButton size

Marco Martin noreply at phabricator.kde.org
Mon Mar 12 15:35:07 UTC 2018


mart added a comment.


  In D11205#222643 <https://phabricator.kde.org/D11205#222643>, @ngraham wrote:
  
  > I think the real error is deriving the button size from a Spacing value and not a Size value. We should fix that, or else we'll have to do the same thing if we ever change the spacing again.
  
  
  indeed, tough the idea was to size it depending on iconsizes and using the largespacing value as padding, which is a concept used a lot (would be space used outside the icon, so semantically would make sense).
  
  i think the patch would be correct, following this reasoning

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11205

To: icota, #kirigami, mart
Cc: ngraham, plasma-devel, #kirigami, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180312/24c8b5d7/attachment.html>


More information about the Plasma-devel mailing list