D11197: Allow OverlaySheets to omit built-in close buttons

Nathaniel Graham noreply at phabricator.kde.org
Sat Mar 10 00:08:18 UTC 2018


ngraham created this revision.
ngraham added reviewers: mart, Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Most of the time we want an OverlayDialog to draw a close button so clients don't have to. But sometimes clients want to draw their own close buttons, for example to use the OverlaySheet as a dialog bux with a Cancel button. In these circumstances, we don't need OverlaySheet to draw its own close button. This patch makes that possible.

TEST PLAN
  Tested in Discover after applying the patch and adding `showCloseButton: false` to DiscoverWindow.qml's proceedDialog:

REPOSITORY
  R169 Kirigami

BRANCH
  overlay-sheet-without-close-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11197

AFFECTED FILES
  src/controls/templates/OverlaySheet.qml

To: ngraham, mart, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180310/056a6701/attachment.html>


More information about the Plasma-devel mailing list