plasma-desktop-5.12.3 bug report

[Nate Graham]

Hi David,
Bug reports are submitted using Bugzilla, not email. See:
- https://bugs.kde.org/
- https://community.kde.org/Get_Involved/Bug_Reporting

Nate


On 03/07/2018 02:02 AM, David Binderman wrote:
> Hello there,
> 
> 
> plasma-desktop-5.12.3/kcms/hardware/joystick/joydevice.cpp:188]: (error) 
> Memory leak: oldCorr
> 
> 
> Source code is
> 
>    if ( ::ioctl(fd, JSIOCGCORR, oldCorr) == -1 )
>    {
>      ::close(fd);
>      delete [] oldCorr;
>      return JoyDevice::ERR_GET_CORR;
>    }
> 
>    if (bt < 0) {
>        return JoyDevice::ERR_GET_BUTTONS;
>    }
> 
> One if statement tidies things up, the other doesn't. Suggest code rework.
> It would also be more efficient if the sanity check for bt were moved
> to just after where it is set up.
> 
> Regards
> 
> David Binderman
> 
>