D11133: Fix minimise all applet on wayland with an active window

David Edmundson noreply at phabricator.kde.org
Wed Mar 7 16:12:45 UTC 2018


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  There's an async round trip after requesting isMinimized to kwin and
  then back to Plasma with the updated roles.
  
  There's a quirk on wayland that IsActive will update before we get
  isMinimized changed. The old code would see that a window is currently
  not minimised and deactivate the effect.
  
  This patch checks the roles to only check after IsMinimized changes.

TEST PLAN
  More clicking

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11133

AFFECTED FILES
  applets/minimizeall/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180307/205a1493/attachment-0001.html>


More information about the Plasma-devel mailing list