D11061: Migration request from IBusConfig to GSettings

Xuetian Weng noreply at phabricator.kde.org
Wed Mar 7 09:25:16 UTC 2018


xuetianweng added inline comments.

INLINE COMMENTS

> panel.cpp:922
> +    impanel_update_engines(impanel, var_engines);
> +    if (var_engines)
> +        g_variant_unref(var_engines);

https://community.kde.org/Policies/Kdelibs_Coding_Style#Braces

Always use braces

> panel.cpp:933
> +    impanel_update_triggers(impanel, var_triggers);
> +    if (var_triggers)
> +        g_variant_unref(var_triggers);

Same as above

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180307/7cddaa18/attachment.html>


More information about the Plasma-devel mailing list