D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

xuetianweng requested changes to this revision.
xuetianweng added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> panel.cpp:1049
> +    g_signal_handlers_disconnect_by_func (impanel->settings_hotkey, (gpointer)impanel_settings_changed_callback, impanel);
> +    g_clear_pointer (&impanel->settings_general, g_object_unref);
> +    g_clear_pointer (&impanel->settings_hotkey, g_object_unref);

I think you can use g_clear_object here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180306/c6ca72b1/attachment.html>