D11064: add preview images to fonts kcm

Julian Wolff noreply at phabricator.kde.org
Tue Mar 6 08:10:08 UTC 2018


progwolff added inline comments.

INLINE COMMENTS

> davidedmundson wrote in previewrenderengine.cpp:136
> change to
> 
> QImage image(draw(name, style,...));
> image.setDevicePixelRatio(ratio);
> return image;
> 
> This keeps the metadata of the image scaling with the image, and then the Image item knows automatically what the logical of this image is.

Thanks, this would be much cleaner. Sadly it doesn't seem to work.
I tried this before. Also tried `setDotsPerMeterX`.

The image is drawn too big with `QT_SCREEN_SCALE_FACTORS=2`:
F5743060: Screenshot_20180306_090622.png <https://phabricator.kde.org/F5743060>

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180306/d5af7d28/attachment.html>


More information about the Plasma-devel mailing list