D11064: add preview images to fonts kcm
Julian Wolff
noreply at phabricator.kde.org
Mon Mar 5 18:13:07 UTC 2018
progwolff updated this revision to Diff 28737.
progwolff marked 7 inline comments as done.
progwolff edited the summary of this revision.
progwolff added a comment.
- revert QtQuick.Controls version
- coding style, unneccessary defaults, Label instead of Text
- split only once, add range check
- move include guards
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11064?vs=28735&id=28737
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D11064
AFFECTED FILES
kcms/CMakeLists.txt
kcms/fonts/CMakeLists.txt
kcms/fonts/fonts.cpp
kcms/fonts/package/contents/ui/main.qml
kcms/fonts/previewimageprovider.cpp
kcms/fonts/previewimageprovider.h
kcms/fonts/previewrenderengine.cpp
kcms/fonts/previewrenderengine.h
kcms/kfontinst/lib/FcEngine.cpp
kcms/kfontinst/lib/FcEngine.h
To: progwolff, #plasma, harmathy, mart
Cc: abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180305/aa2ac212/attachment.html>
More information about the Plasma-devel
mailing list