D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Mar 5 08:30:48 UTC 2018


broulik added inline comments.

INLINE COMMENTS

> ToolTipInstance.qml:349
> +                            if (canPause) {
> +                                mpris2Source.playPause(mprisSourceName);
> +                            } else if (playing) {

Same as with media controller, please do not mix playPause with manual play+pause, it makes the code convoluted and hard to follow, just manually do it then.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11025

To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180305/14e75c0d/attachment.html>


More information about the Plasma-devel mailing list