D10991: [mpris2 dataengine] Fix media key handling to match MediaPlayer2.Player

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Sat Mar 3 13:54:22 UTC 2018


kossebau created this revision.
kossebau added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  - first check CanControl property, as it overrules things
  - next check each action Can* property, to spare D-Bus call and app activation if false
  - support CanPause and only call PlayPause is possible, otherwise use Play

TEST PLAN
  Vlc can be controlled by keyboard media keys as before,
  Gwenview patched to support MPRIS (with CanPause=false) can now be
  controlled with the Play/Pause media key.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixMPRISMediaKeysHandling

REVISION DETAIL
  https://phabricator.kde.org/D10991

AFFECTED FILES
  dataengines/mpris2/multiplexedservice.cpp

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180303/f87f215e/attachment.html>


More information about the Plasma-devel mailing list