D10243: Improve visibility of disconnected Wi-Fi icons
Nathaniel Graham
noreply at phabricator.kde.org
Fri Mar 2 22:50:36 UTC 2018
ngraham added a comment.
In D10243#217119 <https://phabricator.kde.org/D10243#217119>, @andreask wrote:
> I'm that much confuse maybe someone can make a screenshot what should be changed the opacity was already changed.
I'm confused too, since this Phabricator revision is open and in "needs revision" state, yet you committed something anyway: https://cgit.kde.org/breeze-icons.git/commit/?id=2a6192a4196a5977362fe03bdf6637530c47ec6f
That commit wound up in KDE Frameworks 5.43, but the icon wasn't visibly changed. Because of the confusion here regarding the status of this work, I announced to the world in a blog post a few weeks ago that https://bugs.kde.org/show_bug.cgi?id=384018 was fixed in KDE Frameworks 5.43, only to be corrected by the wider internet once it was released and the issue persisted. Oops.
This is why we use Phabricator: to make sure that proposed patches actually fix the issue they're targeting, and that their status is clear to all. If you're having trouble with Phabricator and `arc`, I'd be happy to help you out anytime you like. We also have high-quality documentation at https://community.kde.org/Infrastructure/Phabricator
And finally: **what is the status of this patch?** Was it already committed as https://cgit.kde.org/breeze-icons.git/commit/?id=2a6192a4196a5977362fe03bdf6637530c47ec6f, or was that separate?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10243
To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: abetts, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180302/c60b167f/attachment-0001.html>
More information about the Plasma-devel
mailing list