D10461: GMenu-DBusMenu-Proxy

[Marco Martin]

mart accepted this revision as: mart.
mart added a comment.
This revision is now accepted and ready to land.


  looks good to me, partial shipit, is so big that i think is better if another one reviews it too

INLINE COMMENTS

> window.cpp:288
> +    } else {
> +        emit LayoutUpdated(2 /*revision*/, id);
> +    }

always 2? maybe needs a more in depth comment?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10461

To: broulik, #plasma, mart
Cc: mart, rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180301/44eb3ccd/attachment.html>