D13793: [Icons KCM] Load preview pixmaps for animation on-demand and cache them

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> main.cpp:484
>  {
> +    const QString cacheKey = themeName + QLatin1Char('@') + QString::number(size) + QLatin1Char('@') + QString::number(dpr,'f',1) + QLatin1Char('@') + QString::number(limit);
> +

so if you request previewIcons with a limit of 6 then request again with a limit of 12 you're duplicating the first 6 in another cache.

If you're going to have this limit, would having a cache per icon then building the list on every invocation would be cleander?

(would also allow use of QPixmapCache which has a nice auto-expunge)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13793

To: broulik, #plasma, mart
Cc: davidedmundson, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180629/633e71e0/attachment.html>