D13793: [Icons KCM] Load preview pixmaps for animation on-demand and cache them

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> main.h:110
> +    // ListView deletes and recreates delegates as you scroll, so once we generated previews, cache them
> +    QHash<QString, QVariantList/*QList<QPixmap>*/> m_previewCache;
> +

leftovers?

> main.qml:156
>                      Qt.callLater(function() {
> -                        previews = kcm.previewIcons(model.themeName, Math.min(thumbFlow.iconWidth, thumbFlow.iconHeight), Screen.devicePixelRatio)
> +                        thumbFlow.loadPreviews(6 /*limit*/);
>                      });

reason for 6?
should be at least documented

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13793

To: broulik, #plasma
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180629/088b8e4d/attachment-0001.html>